device_memory_manager.inc 20 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568
  1. // SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project
  2. // SPDX-License-Identifier: GPL-2.0-or-later
  3. #include <atomic>
  4. #include <limits>
  5. #include <memory>
  6. #include <type_traits>
  7. #include "common/address_space.h"
  8. #include "common/address_space.inc"
  9. #include "common/alignment.h"
  10. #include "common/assert.h"
  11. #include "common/div_ceil.h"
  12. #include "common/scope_exit.h"
  13. #include "core/device_memory.h"
  14. #include "core/device_memory_manager.h"
  15. #include "core/memory.h"
  16. namespace Core {
  17. namespace {
  18. class MultiAddressContainer {
  19. public:
  20. MultiAddressContainer() = default;
  21. ~MultiAddressContainer() = default;
  22. void GatherValues(u32 start_entry, Common::ScratchBuffer<u32>& buffer) {
  23. buffer.resize(8);
  24. buffer.resize(0);
  25. size_t index = 0;
  26. const auto add_value = [&](u32 value) {
  27. buffer[index] = value;
  28. index++;
  29. buffer.resize(index);
  30. };
  31. u32 iter_entry = start_entry;
  32. Entry* current = &storage[iter_entry - 1];
  33. add_value(current->value);
  34. while (current->next_entry != 0) {
  35. iter_entry = current->next_entry;
  36. current = &storage[iter_entry - 1];
  37. add_value(current->value);
  38. }
  39. }
  40. u32 Register(u32 value) {
  41. return RegisterImplementation(value);
  42. }
  43. void Register(u32 value, u32 start_entry) {
  44. auto entry_id = RegisterImplementation(value);
  45. u32 iter_entry = start_entry;
  46. Entry* current = &storage[iter_entry - 1];
  47. while (current->next_entry != 0) {
  48. iter_entry = current->next_entry;
  49. current = &storage[iter_entry - 1];
  50. }
  51. current->next_entry = entry_id;
  52. }
  53. std::pair<bool, u32> Unregister(u32 value, u32 start_entry) {
  54. u32 iter_entry = start_entry;
  55. Entry* previous{};
  56. Entry* current = &storage[iter_entry - 1];
  57. Entry* next{};
  58. bool more_than_one_remaining = false;
  59. u32 result_start{start_entry};
  60. size_t count = 0;
  61. while (current->value != value) {
  62. count++;
  63. previous = current;
  64. iter_entry = current->next_entry;
  65. current = &storage[iter_entry - 1];
  66. }
  67. // Find next
  68. u32 next_entry = current->next_entry;
  69. if (next_entry != 0) {
  70. next = &storage[next_entry - 1];
  71. more_than_one_remaining = next->next_entry != 0 || previous != nullptr;
  72. }
  73. if (previous) {
  74. previous->next_entry = next_entry;
  75. } else {
  76. result_start = next_entry;
  77. }
  78. free_entries.emplace_back(iter_entry);
  79. return std::make_pair(more_than_one_remaining || count > 1, result_start);
  80. }
  81. u32 ReleaseEntry(u32 start_entry) {
  82. Entry* current = &storage[start_entry - 1];
  83. free_entries.emplace_back(start_entry);
  84. return current->value;
  85. }
  86. private:
  87. u32 RegisterImplementation(u32 value) {
  88. auto entry_id = GetNewEntry();
  89. auto& entry = storage[entry_id - 1];
  90. entry.next_entry = 0;
  91. entry.value = value;
  92. return entry_id;
  93. }
  94. u32 GetNewEntry() {
  95. if (!free_entries.empty()) {
  96. u32 result = free_entries.front();
  97. free_entries.pop_front();
  98. return result;
  99. }
  100. storage.emplace_back();
  101. u32 new_entry = static_cast<u32>(storage.size());
  102. return new_entry;
  103. }
  104. struct Entry {
  105. u32 next_entry{};
  106. u32 value{};
  107. };
  108. std::deque<Entry> storage;
  109. std::deque<u32> free_entries;
  110. };
  111. struct EmptyAllocator {
  112. EmptyAllocator([[maybe_unused]] DAddr address) {}
  113. };
  114. } // namespace
  115. template <typename DTraits>
  116. struct DeviceMemoryManagerAllocator {
  117. static constexpr size_t device_virtual_bits = DTraits::device_virtual_bits;
  118. static constexpr DAddr first_address = 1ULL << Memory::YUZU_PAGEBITS;
  119. static constexpr DAddr max_device_area = 1ULL << device_virtual_bits;
  120. DeviceMemoryManagerAllocator() : main_allocator(first_address) {}
  121. Common::FlatAllocator<DAddr, 0, device_virtual_bits> main_allocator;
  122. MultiAddressContainer multi_dev_address;
  123. /// Returns true when vaddr -> vaddr+size is fully contained in the buffer
  124. template <bool pin_area>
  125. [[nodiscard]] bool IsInBounds(VAddr addr, u64 size) const noexcept {
  126. return addr >= 0 && addr + size <= max_device_area;
  127. }
  128. DAddr Allocate(size_t size) {
  129. return main_allocator.Allocate(size);
  130. }
  131. void AllocateFixed(DAddr b_address, size_t b_size) {
  132. main_allocator.AllocateFixed(b_address, b_size);
  133. }
  134. void Free(DAddr b_address, size_t b_size) {
  135. main_allocator.Free(b_address, b_size);
  136. }
  137. };
  138. template <typename Traits>
  139. DeviceMemoryManager<Traits>::DeviceMemoryManager(const DeviceMemory& device_memory_)
  140. : physical_base{reinterpret_cast<const uintptr_t>(device_memory_.buffer.BackingBasePointer())},
  141. interface{nullptr}, compressed_physical_ptr(device_as_size >> Memory::YUZU_PAGEBITS),
  142. compressed_device_addr(1ULL << (physical_max_bits - Memory::YUZU_PAGEBITS)),
  143. continuity_tracker(device_as_size >> Memory::YUZU_PAGEBITS),
  144. cpu_backing_address(device_as_size >> Memory::YUZU_PAGEBITS) {
  145. impl = std::make_unique<DeviceMemoryManagerAllocator<Traits>>();
  146. cached_pages = std::make_unique<CachedPages>();
  147. }
  148. template <typename Traits>
  149. DeviceMemoryManager<Traits>::~DeviceMemoryManager() = default;
  150. template <typename Traits>
  151. void DeviceMemoryManager<Traits>::BindInterface(DeviceInterface* interface_) {
  152. interface = interface_;
  153. }
  154. template <typename Traits>
  155. DAddr DeviceMemoryManager<Traits>::Allocate(size_t size) {
  156. return impl->Allocate(size);
  157. }
  158. template <typename Traits>
  159. void DeviceMemoryManager<Traits>::AllocateFixed(DAddr start, size_t size) {
  160. return impl->AllocateFixed(start, size);
  161. }
  162. template <typename Traits>
  163. void DeviceMemoryManager<Traits>::Free(DAddr start, size_t size) {
  164. impl->Free(start, size);
  165. }
  166. template <typename Traits>
  167. void DeviceMemoryManager<Traits>::Map(DAddr address, VAddr virtual_address, size_t size,
  168. size_t process_id, bool track) {
  169. Core::Memory::Memory* process_memory = registered_processes[process_id];
  170. size_t start_page_d = address >> Memory::YUZU_PAGEBITS;
  171. size_t num_pages = Common::AlignUp(size, Memory::YUZU_PAGESIZE) >> Memory::YUZU_PAGEBITS;
  172. std::scoped_lock lk(mapping_guard);
  173. for (size_t i = 0; i < num_pages; i++) {
  174. const VAddr new_vaddress = virtual_address + i * Memory::YUZU_PAGESIZE;
  175. auto* ptr = process_memory->GetPointerSilent(Common::ProcessAddress(new_vaddress));
  176. if (ptr == nullptr) [[unlikely]] {
  177. compressed_physical_ptr[start_page_d + i] = 0;
  178. continue;
  179. }
  180. auto phys_addr = static_cast<u32>(GetRawPhysicalAddr(ptr) >> Memory::YUZU_PAGEBITS) + 1U;
  181. compressed_physical_ptr[start_page_d + i] = phys_addr;
  182. InsertCPUBacking(start_page_d + i, new_vaddress, process_id);
  183. const u32 base_dev = compressed_device_addr[phys_addr - 1U];
  184. const u32 new_dev = static_cast<u32>(start_page_d + i);
  185. if (base_dev == 0) [[likely]] {
  186. compressed_device_addr[phys_addr - 1U] = new_dev;
  187. continue;
  188. }
  189. u32 start_id = base_dev & MULTI_MASK;
  190. if ((base_dev >> MULTI_FLAG_BITS) == 0) {
  191. start_id = impl->multi_dev_address.Register(base_dev);
  192. compressed_device_addr[phys_addr - 1U] = MULTI_FLAG | start_id;
  193. }
  194. impl->multi_dev_address.Register(new_dev, start_id);
  195. }
  196. if (track) {
  197. TrackContinuityImpl(address, virtual_address, size, process_id);
  198. }
  199. }
  200. template <typename Traits>
  201. void DeviceMemoryManager<Traits>::Unmap(DAddr address, size_t size) {
  202. size_t start_page_d = address >> Memory::YUZU_PAGEBITS;
  203. size_t num_pages = Common::AlignUp(size, Memory::YUZU_PAGESIZE) >> Memory::YUZU_PAGEBITS;
  204. interface->InvalidateRegion(address, size);
  205. std::scoped_lock lk(mapping_guard);
  206. for (size_t i = 0; i < num_pages; i++) {
  207. auto phys_addr = compressed_physical_ptr[start_page_d + i];
  208. compressed_physical_ptr[start_page_d + i] = 0;
  209. cpu_backing_address[start_page_d + i] = 0;
  210. if (phys_addr != 0) [[likely]] {
  211. const u32 base_dev = compressed_device_addr[phys_addr - 1U];
  212. if ((base_dev >> MULTI_FLAG_BITS) == 0) [[likely]] {
  213. compressed_device_addr[phys_addr - 1] = 0;
  214. continue;
  215. }
  216. const auto [more_entries, new_start] = impl->multi_dev_address.Unregister(
  217. static_cast<u32>(start_page_d + i), base_dev & MULTI_MASK);
  218. if (!more_entries) {
  219. compressed_device_addr[phys_addr - 1] =
  220. impl->multi_dev_address.ReleaseEntry(new_start);
  221. continue;
  222. }
  223. compressed_device_addr[phys_addr - 1] = new_start | MULTI_FLAG;
  224. }
  225. }
  226. }
  227. template <typename Traits>
  228. void DeviceMemoryManager<Traits>::TrackContinuityImpl(DAddr address, VAddr virtual_address,
  229. size_t size, size_t process_id) {
  230. Core::Memory::Memory* process_memory = registered_processes[process_id];
  231. size_t start_page_d = address >> Memory::YUZU_PAGEBITS;
  232. size_t num_pages = Common::AlignUp(size, Memory::YUZU_PAGESIZE) >> Memory::YUZU_PAGEBITS;
  233. uintptr_t last_ptr = 0;
  234. size_t page_count = 1;
  235. for (size_t i = num_pages; i > 0; i--) {
  236. size_t index = i - 1;
  237. const VAddr new_vaddress = virtual_address + index * Memory::YUZU_PAGESIZE;
  238. const uintptr_t new_ptr = reinterpret_cast<uintptr_t>(
  239. process_memory->GetPointerSilent(Common::ProcessAddress(new_vaddress)));
  240. if (new_ptr + page_size == last_ptr) {
  241. page_count++;
  242. } else {
  243. page_count = 1;
  244. }
  245. last_ptr = new_ptr;
  246. continuity_tracker[start_page_d + index] = static_cast<u32>(page_count);
  247. }
  248. }
  249. template <typename Traits>
  250. u8* DeviceMemoryManager<Traits>::GetSpan(const DAddr src_addr, const std::size_t size) {
  251. size_t page_index = src_addr >> page_bits;
  252. size_t subbits = src_addr & page_mask;
  253. if ((continuity_tracker[page_index] << page_bits) >= size + subbits) {
  254. return GetPointer<u8>(src_addr);
  255. }
  256. return nullptr;
  257. }
  258. template <typename Traits>
  259. const u8* DeviceMemoryManager<Traits>::GetSpan(const DAddr src_addr, const std::size_t size) const {
  260. size_t page_index = src_addr >> page_bits;
  261. size_t subbits = src_addr & page_mask;
  262. if ((continuity_tracker[page_index] << page_bits) >= size + subbits) {
  263. return GetPointer<u8>(src_addr);
  264. }
  265. return nullptr;
  266. }
  267. template <typename Traits>
  268. void DeviceMemoryManager<Traits>::InnerGatherDeviceAddresses(Common::ScratchBuffer<u32>& buffer,
  269. PAddr address) {
  270. size_t phys_addr = address >> page_bits;
  271. std::scoped_lock lk(mapping_guard);
  272. u32 backing = compressed_device_addr[phys_addr];
  273. if ((backing >> MULTI_FLAG_BITS) != 0) {
  274. impl->multi_dev_address.GatherValues(backing & MULTI_MASK, buffer);
  275. return;
  276. }
  277. buffer.resize(1);
  278. buffer[0] = backing;
  279. }
  280. template <typename Traits>
  281. template <typename T>
  282. T* DeviceMemoryManager<Traits>::GetPointer(DAddr address) {
  283. const size_t index = address >> Memory::YUZU_PAGEBITS;
  284. const size_t offset = address & Memory::YUZU_PAGEMASK;
  285. auto phys_addr = compressed_physical_ptr[index];
  286. if (phys_addr == 0) [[unlikely]] {
  287. return nullptr;
  288. }
  289. return GetPointerFromRaw<T>(
  290. static_cast<PAddr>(((phys_addr - 1) << Memory::YUZU_PAGEBITS) + offset));
  291. }
  292. template <typename Traits>
  293. template <typename T>
  294. const T* DeviceMemoryManager<Traits>::GetPointer(DAddr address) const {
  295. const size_t index = address >> Memory::YUZU_PAGEBITS;
  296. const size_t offset = address & Memory::YUZU_PAGEMASK;
  297. auto phys_addr = compressed_physical_ptr[index];
  298. if (phys_addr == 0) [[unlikely]] {
  299. return nullptr;
  300. }
  301. return GetPointerFromRaw<T>(
  302. static_cast<PAddr>(((phys_addr - 1) << Memory::YUZU_PAGEBITS) + offset));
  303. }
  304. template <typename Traits>
  305. template <typename T>
  306. void DeviceMemoryManager<Traits>::Write(DAddr address, T value) {
  307. T* ptr = GetPointer<T>(address);
  308. if (!ptr) [[unlikely]] {
  309. return;
  310. }
  311. std::memcpy(ptr, &value, sizeof(T));
  312. }
  313. template <typename Traits>
  314. template <typename T>
  315. T DeviceMemoryManager<Traits>::Read(DAddr address) const {
  316. const T* ptr = GetPointer<T>(address);
  317. T result{};
  318. if (!ptr) [[unlikely]] {
  319. return result;
  320. }
  321. std::memcpy(&result, ptr, sizeof(T));
  322. return result;
  323. }
  324. template <typename Traits>
  325. void DeviceMemoryManager<Traits>::WalkBlock(DAddr addr, std::size_t size, auto on_unmapped,
  326. auto on_memory, auto increment) {
  327. std::size_t remaining_size = size;
  328. std::size_t page_index = addr >> Memory::YUZU_PAGEBITS;
  329. std::size_t page_offset = addr & Memory::YUZU_PAGEMASK;
  330. while (remaining_size) {
  331. const size_t next_pages = static_cast<std::size_t>(continuity_tracker[page_index]);
  332. const std::size_t copy_amount =
  333. std::min((next_pages << Memory::YUZU_PAGEBITS) - page_offset, remaining_size);
  334. const auto current_vaddr =
  335. static_cast<u64>((page_index << Memory::YUZU_PAGEBITS) + page_offset);
  336. SCOPE_EXIT({
  337. page_index += next_pages;
  338. page_offset = 0;
  339. increment(copy_amount);
  340. remaining_size -= copy_amount;
  341. });
  342. auto phys_addr = compressed_physical_ptr[page_index];
  343. if (phys_addr == 0) {
  344. on_unmapped(copy_amount, current_vaddr);
  345. continue;
  346. }
  347. auto* mem_ptr = GetPointerFromRaw<u8>(
  348. static_cast<PAddr>(((phys_addr - 1) << Memory::YUZU_PAGEBITS) + page_offset));
  349. on_memory(copy_amount, mem_ptr);
  350. }
  351. }
  352. template <typename Traits>
  353. void DeviceMemoryManager<Traits>::ReadBlock(DAddr address, void* dest_pointer, size_t size) {
  354. interface->FlushRegion(address, size);
  355. WalkBlock(
  356. address, size,
  357. [&](size_t copy_amount, DAddr current_vaddr) {
  358. LOG_ERROR(
  359. HW_Memory,
  360. "Unmapped Device ReadBlock @ 0x{:016X} (start address = 0x{:016X}, size = {})",
  361. current_vaddr, address, size);
  362. std::memset(dest_pointer, 0, copy_amount);
  363. },
  364. [&](size_t copy_amount, const u8* const src_ptr) {
  365. std::memcpy(dest_pointer, src_ptr, copy_amount);
  366. },
  367. [&](const std::size_t copy_amount) {
  368. dest_pointer = static_cast<u8*>(dest_pointer) + copy_amount;
  369. });
  370. }
  371. template <typename Traits>
  372. void DeviceMemoryManager<Traits>::WriteBlock(DAddr address, const void* src_pointer, size_t size) {
  373. WalkBlock(
  374. address, size,
  375. [&](size_t copy_amount, DAddr current_vaddr) {
  376. LOG_ERROR(
  377. HW_Memory,
  378. "Unmapped Device WriteBlock @ 0x{:016X} (start address = 0x{:016X}, size = {})",
  379. current_vaddr, address, size);
  380. },
  381. [&](size_t copy_amount, u8* const dst_ptr) {
  382. std::memcpy(dst_ptr, src_pointer, copy_amount);
  383. },
  384. [&](const std::size_t copy_amount) {
  385. src_pointer = static_cast<const u8*>(src_pointer) + copy_amount;
  386. });
  387. interface->InvalidateRegion(address, size);
  388. }
  389. template <typename Traits>
  390. void DeviceMemoryManager<Traits>::ReadBlockUnsafe(DAddr address, void* dest_pointer, size_t size) {
  391. WalkBlock(
  392. address, size,
  393. [&](size_t copy_amount, DAddr current_vaddr) {
  394. LOG_ERROR(
  395. HW_Memory,
  396. "Unmapped Device ReadBlock @ 0x{:016X} (start address = 0x{:016X}, size = {})",
  397. current_vaddr, address, size);
  398. std::memset(dest_pointer, 0, copy_amount);
  399. },
  400. [&](size_t copy_amount, const u8* const src_ptr) {
  401. std::memcpy(dest_pointer, src_ptr, copy_amount);
  402. },
  403. [&](const std::size_t copy_amount) {
  404. dest_pointer = static_cast<u8*>(dest_pointer) + copy_amount;
  405. });
  406. }
  407. template <typename Traits>
  408. void DeviceMemoryManager<Traits>::WriteBlockUnsafe(DAddr address, const void* src_pointer,
  409. size_t size) {
  410. WalkBlock(
  411. address, size,
  412. [&](size_t copy_amount, DAddr current_vaddr) {
  413. LOG_ERROR(
  414. HW_Memory,
  415. "Unmapped Device WriteBlock @ 0x{:016X} (start address = 0x{:016X}, size = {})",
  416. current_vaddr, address, size);
  417. },
  418. [&](size_t copy_amount, u8* const dst_ptr) {
  419. std::memcpy(dst_ptr, src_pointer, copy_amount);
  420. },
  421. [&](const std::size_t copy_amount) {
  422. src_pointer = static_cast<const u8*>(src_pointer) + copy_amount;
  423. });
  424. }
  425. template <typename Traits>
  426. size_t DeviceMemoryManager<Traits>::RegisterProcess(Memory::Memory* memory_interface) {
  427. size_t new_id;
  428. if (!id_pool.empty()) {
  429. new_id = id_pool.front();
  430. id_pool.pop_front();
  431. registered_processes[new_id] = memory_interface;
  432. } else {
  433. registered_processes.emplace_back(memory_interface);
  434. new_id = registered_processes.size() - 1U;
  435. }
  436. return new_id;
  437. }
  438. template <typename Traits>
  439. void DeviceMemoryManager<Traits>::UnregisterProcess(size_t id) {
  440. registered_processes[id] = nullptr;
  441. id_pool.push_front(id);
  442. }
  443. template <typename Traits>
  444. void DeviceMemoryManager<Traits>::UpdatePagesCachedCount(DAddr addr, size_t size, s32 delta) {
  445. bool locked = false;
  446. auto lock = [&] {
  447. if (!locked) {
  448. counter_guard.lock();
  449. locked = true;
  450. }
  451. };
  452. SCOPE_EXIT({
  453. if (locked) {
  454. counter_guard.unlock();
  455. }
  456. });
  457. u64 uncache_begin = 0;
  458. u64 cache_begin = 0;
  459. u64 uncache_bytes = 0;
  460. u64 cache_bytes = 0;
  461. const auto MarkRegionCaching = &DeviceMemoryManager<Traits>::DeviceMethods::MarkRegionCaching;
  462. std::atomic_thread_fence(std::memory_order_acquire);
  463. const size_t page_end = Common::DivCeil(addr + size, Memory::YUZU_PAGESIZE);
  464. size_t page = addr >> Memory::YUZU_PAGEBITS;
  465. auto [process_id, base_vaddress] = ExtractCPUBacking(page);
  466. size_t vpage = base_vaddress >> Memory::YUZU_PAGEBITS;
  467. auto* memory_interface = registered_processes[process_id];
  468. for (; page != page_end; ++page) {
  469. std::atomic_uint8_t& count = cached_pages->at(page >> 3).Count(page);
  470. if (delta > 0) {
  471. ASSERT_MSG(count.load(std::memory_order::relaxed) < std::numeric_limits<u8>::max(),
  472. "Count may overflow!");
  473. } else if (delta < 0) {
  474. ASSERT_MSG(count.load(std::memory_order::relaxed) > 0, "Count may underflow!");
  475. } else {
  476. ASSERT_MSG(false, "Delta must be non-zero!");
  477. }
  478. // Adds or subtracts 1, as count is a unsigned 8-bit value
  479. count.fetch_add(static_cast<u8>(delta), std::memory_order_release);
  480. // Assume delta is either -1 or 1
  481. if (count.load(std::memory_order::relaxed) == 0) {
  482. if (uncache_bytes == 0) {
  483. uncache_begin = vpage;
  484. }
  485. uncache_bytes += Memory::YUZU_PAGESIZE;
  486. } else if (uncache_bytes > 0) {
  487. lock();
  488. MarkRegionCaching(memory_interface, uncache_begin << Memory::YUZU_PAGEBITS,
  489. uncache_bytes, false);
  490. uncache_bytes = 0;
  491. }
  492. if (count.load(std::memory_order::relaxed) == 1 && delta > 0) {
  493. if (cache_bytes == 0) {
  494. cache_begin = vpage;
  495. }
  496. cache_bytes += Memory::YUZU_PAGESIZE;
  497. } else if (cache_bytes > 0) {
  498. lock();
  499. MarkRegionCaching(memory_interface, cache_begin << Memory::YUZU_PAGEBITS, cache_bytes,
  500. true);
  501. cache_bytes = 0;
  502. }
  503. vpage++;
  504. }
  505. if (uncache_bytes > 0) {
  506. lock();
  507. MarkRegionCaching(memory_interface, uncache_begin << Memory::YUZU_PAGEBITS, uncache_bytes,
  508. false);
  509. }
  510. if (cache_bytes > 0) {
  511. lock();
  512. MarkRegionCaching(memory_interface, cache_begin << Memory::YUZU_PAGEBITS, cache_bytes,
  513. true);
  514. }
  515. }
  516. } // namespace Core