Ver código fonte

yuzu/main: Resolve precedence bug within CalculateRomFSEntrySize()

Ternary operators have a lower precedence than arithmetic operators, so
what was actually occurring here is "return (out + full) ? x : y" which most
definitely isn't intended, given we calculate out recursively above. We
were essentially doing a lot of work for nothing.
Lioncash 7 anos atrás
pai
commit
f646ca874d
1 arquivos alterados com 1 adições e 1 exclusões
  1. 1 1
      src/yuzu/main.cpp

+ 1 - 1
src/yuzu/main.cpp

@@ -763,7 +763,7 @@ static std::size_t CalculateRomFSEntrySize(const FileSys::VirtualDir& dir, bool
         out += 1 + CalculateRomFSEntrySize(subdir, full);
     }
 
-    return out + full ? dir->GetFiles().size() : 0;
+    return out + (full ? dir->GetFiles().size() : 0);
 }
 
 static bool RomFSRawCopy(QProgressDialog& dialog, const FileSys::VirtualDir& src,