ソースを参照

sdl_impl: Make use of std::move on std::string where applicable

Avoids redundant copies.
Lioncash 5 年 前
コミット
f2a680ca89
1 ファイル変更3 行追加3 行削除
  1. 3 3
      src/input_common/sdl/sdl_impl.cpp

+ 3 - 3
src/input_common/sdl/sdl_impl.cpp

@@ -577,7 +577,7 @@ Common::ParamPackage BuildAnalogParamPackageForButton(int port, std::string guid
                                                       float value = 0.1f) {
                                                       float value = 0.1f) {
     Common::ParamPackage params({{"engine", "sdl"}});
     Common::ParamPackage params({{"engine", "sdl"}});
     params.Set("port", port);
     params.Set("port", port);
-    params.Set("guid", guid);
+    params.Set("guid", std::move(guid));
     params.Set("axis", axis);
     params.Set("axis", axis);
     if (value > 0) {
     if (value > 0) {
         params.Set("direction", "+");
         params.Set("direction", "+");
@@ -592,7 +592,7 @@ Common::ParamPackage BuildAnalogParamPackageForButton(int port, std::string guid
 Common::ParamPackage BuildButtonParamPackageForButton(int port, std::string guid, u8 button) {
 Common::ParamPackage BuildButtonParamPackageForButton(int port, std::string guid, u8 button) {
     Common::ParamPackage params({{"engine", "sdl"}});
     Common::ParamPackage params({{"engine", "sdl"}});
     params.Set("port", port);
     params.Set("port", port);
-    params.Set("guid", guid);
+    params.Set("guid", std::move(guid));
     params.Set("button", button);
     params.Set("button", button);
     return params;
     return params;
 }
 }
@@ -601,7 +601,7 @@ Common::ParamPackage BuildHatParamPackageForButton(int port, std::string guid, u
     Common::ParamPackage params({{"engine", "sdl"}});
     Common::ParamPackage params({{"engine", "sdl"}});
 
 
     params.Set("port", port);
     params.Set("port", port);
-    params.Set("guid", guid);
+    params.Set("guid", std::move(guid));
     params.Set("hat", hat);
     params.Set("hat", hat);
     switch (value) {
     switch (value) {
     case SDL_HAT_UP:
     case SDL_HAT_UP: