Procházet zdrojové kódy

settings: Remove unnecessary std::move usages

Addresses review feedback.

Co-authored-by: Mai M. <mathew1800@gmail.com>
lat9nq před 5 roky
rodič
revize
e9cf08c241
1 změnil soubory, kde provedl 12 přidání a 12 odebrání
  1. 12 12
      src/common/settings.h

+ 12 - 12
src/common/settings.h

@@ -170,11 +170,11 @@ public:
     void SetValue(const Type& value) override {
     void SetValue(const Type& value) override {
         Type temp;
         Type temp;
         if (value < minimum) {
         if (value < minimum) {
-            temp = std::move(minimum);
+            temp = minimum;
         } else if (value > maximum) {
         } else if (value > maximum) {
-            temp = std::move(maximum);
+            temp = maximum;
         } else {
         } else {
-            temp = std::move(value);
+            temp = value;
         }
         }
         std::swap(this->global, temp);
         std::swap(this->global, temp);
     }
     }
@@ -188,11 +188,11 @@ public:
     const Type& operator=(const Type& value) override {
     const Type& operator=(const Type& value) override {
         Type temp;
         Type temp;
         if (value < minimum) {
         if (value < minimum) {
-            temp = std::move(minimum);
+            temp = minimum;
         } else if (value > maximum) {
         } else if (value > maximum) {
-            temp = std::move(maximum);
+            temp = maximum;
         } else {
         } else {
-            temp = std::move(value);
+            temp = value;
         }
         }
         std::swap(this->global, temp);
         std::swap(this->global, temp);
         return this->global;
         return this->global;
@@ -344,11 +344,11 @@ public:
     void SetValue(const Type& value) override {
     void SetValue(const Type& value) override {
         Type temp;
         Type temp;
         if (value < this->minimum) {
         if (value < this->minimum) {
-            temp = std::move(this->minimum);
+            temp = this->minimum;
         } else if (value > this->maximum) {
         } else if (value > this->maximum) {
-            temp = std::move(this->maximum);
+            temp = this->maximum;
         } else {
         } else {
-            temp = std::move(value);
+            temp = value;
         }
         }
         if (this->use_global) {
         if (this->use_global) {
             std::swap(this->global, temp);
             std::swap(this->global, temp);
@@ -367,11 +367,11 @@ public:
     const Type& operator=(const Type& value) override {
     const Type& operator=(const Type& value) override {
         Type temp;
         Type temp;
         if (value < this->minimum) {
         if (value < this->minimum) {
-            temp = std::move(this->minimum);
+            temp = this->minimum;
         } else if (value > this->maximum) {
         } else if (value > this->maximum) {
-            temp = std::move(this->maximum);
+            temp = this->maximum;
         } else {
         } else {
-            temp = std::move(value);
+            temp = value;
         }
         }
         if (this->use_global) {
         if (this->use_global) {
             std::swap(this->global, temp);
             std::swap(this->global, temp);