Преглед изворни кода

core/hle/result: Relocate IPC error code to ipc_helpers

Relocates the error code to where it's most related, similar to how all
the other error codes are. Previously we were including a non-generic
error in the main result code header.
Lioncash пре 7 година
родитељ
комит
d870cc5ad7
3 измењених фајлова са 4 додато и 3 уклоњено
  1. 3 0
      src/core/hle/ipc_helpers.h
  2. 0 1
      src/core/hle/result.h
  3. 1 2
      src/core/hle/service/service.cpp

+ 3 - 0
src/core/hle/ipc_helpers.h

@@ -19,9 +19,12 @@
 #include "core/hle/kernel/hle_ipc.h"
 #include "core/hle/kernel/object.h"
 #include "core/hle/kernel/server_session.h"
+#include "core/hle/result.h"
 
 namespace IPC {
 
+constexpr ResultCode ERR_REMOTE_PROCESS_DEAD{ErrorModule::HIPC, 301};
+
 class RequestHelperBase {
 protected:
     Kernel::HLERequestContext* context = nullptr;

+ 0 - 1
src/core/hle/result.h

@@ -17,7 +17,6 @@
  */
 enum class ErrorDescription : u32 {
     Success = 0,
-    RemoteProcessDead = 301,
 };
 
 /**

+ 1 - 2
src/core/hle/service/service.cpp

@@ -11,7 +11,6 @@
 #include "core/hle/ipc.h"
 #include "core/hle/ipc_helpers.h"
 #include "core/hle/kernel/client_port.h"
-#include "core/hle/kernel/handle_table.h"
 #include "core/hle/kernel/kernel.h"
 #include "core/hle/kernel/process.h"
 #include "core/hle/kernel/server_port.h"
@@ -169,7 +168,7 @@ ResultCode ServiceFrameworkBase::HandleSyncRequest(Kernel::HLERequestContext& co
     case IPC::CommandType::Close: {
         IPC::ResponseBuilder rb{context, 2};
         rb.Push(RESULT_SUCCESS);
-        return ResultCode(ErrorModule::HIPC, ErrorDescription::RemoteProcessDead);
+        return IPC::ERR_REMOTE_PROCESS_DEAD;
     }
     case IPC::CommandType::ControlWithContext:
     case IPC::CommandType::Control: {