ソースを参照

nfp: Correct uninitialized size being used within GetTagInfo()

We were previously the name of the object being initialized within its
own initializer, which results in uninitialized data being read.
Lioncash 5 年 前
コミット
d64ba58759
1 ファイル変更1 行追加1 行削除
  1. 1 1
      src/core/hle/service/nfp/nfp.cpp

+ 1 - 1
src/core/hle/service/nfp/nfp.cpp

@@ -215,7 +215,7 @@ private:
         const auto& amiibo = nfp_interface.GetAmiiboBuffer();
         const auto& amiibo = nfp_interface.GetAmiiboBuffer();
         const TagInfo tag_info{
         const TagInfo tag_info{
             .uuid = amiibo.uuid,
             .uuid = amiibo.uuid,
-            .uuid_length = static_cast<u8>(tag_info.uuid.size()),
+            .uuid_length = static_cast<u8>(amiibo.uuid.size()),
             .padding_1 = {},
             .padding_1 = {},
             .protocol = 1, // TODO(ogniK): Figure out actual values
             .protocol = 1, // TODO(ogniK): Figure out actual values
             .tag_type = 2,
             .tag_type = 2,