Эх сурвалжийг харах

Merge pull request #3304 from lioncash/fwd-decl

renderer_opengl/utils: Forward declare private structs
bunnei 6 жил өмнө
parent
commit
d23869811d

+ 14 - 3
src/video_core/renderer_opengl/utils.cpp

@@ -6,16 +6,20 @@
 #include <vector>
 #include <vector>
 
 
 #include <fmt/format.h>
 #include <fmt/format.h>
-
 #include <glad/glad.h>
 #include <glad/glad.h>
 
 
-#include "common/assert.h"
 #include "common/common_types.h"
 #include "common/common_types.h"
-#include "common/scope_exit.h"
 #include "video_core/renderer_opengl/utils.h"
 #include "video_core/renderer_opengl/utils.h"
 
 
 namespace OpenGL {
 namespace OpenGL {
 
 
+struct VertexArrayPushBuffer::Entry {
+    GLuint binding_index{};
+    const GLuint* buffer{};
+    GLintptr offset{};
+    GLsizei stride{};
+};
+
 VertexArrayPushBuffer::VertexArrayPushBuffer() = default;
 VertexArrayPushBuffer::VertexArrayPushBuffer() = default;
 
 
 VertexArrayPushBuffer::~VertexArrayPushBuffer() = default;
 VertexArrayPushBuffer::~VertexArrayPushBuffer() = default;
@@ -47,6 +51,13 @@ void VertexArrayPushBuffer::Bind() {
     }
     }
 }
 }
 
 
+struct BindBuffersRangePushBuffer::Entry {
+    GLuint binding;
+    const GLuint* buffer;
+    GLintptr offset;
+    GLsizeiptr size;
+};
+
 BindBuffersRangePushBuffer::BindBuffersRangePushBuffer(GLenum target) : target{target} {}
 BindBuffersRangePushBuffer::BindBuffersRangePushBuffer(GLenum target) : target{target} {}
 
 
 BindBuffersRangePushBuffer::~BindBuffersRangePushBuffer() = default;
 BindBuffersRangePushBuffer::~BindBuffersRangePushBuffer() = default;

+ 2 - 12
src/video_core/renderer_opengl/utils.h

@@ -26,12 +26,7 @@ public:
     void Bind();
     void Bind();
 
 
 private:
 private:
-    struct Entry {
-        GLuint binding_index{};
-        const GLuint* buffer{};
-        GLintptr offset{};
-        GLsizei stride{};
-    };
+    struct Entry;
 
 
     GLuint vao{};
     GLuint vao{};
     const GLuint* index_buffer{};
     const GLuint* index_buffer{};
@@ -50,12 +45,7 @@ public:
     void Bind();
     void Bind();
 
 
 private:
 private:
-    struct Entry {
-        GLuint binding;
-        const GLuint* buffer;
-        GLintptr offset;
-        GLsizeiptr size;
-    };
+    struct Entry;
 
 
     GLenum target;
     GLenum target;
     std::vector<Entry> entries;
     std::vector<Entry> entries;