Преглед на файлове

Remove the lock entirely as per PR discussion

Correctly unlock mutex before its destruction

As per https://en.cppreference.com/w/cpp/thread/mutex/~mutex destroying a locked mutex is undefined behavior and MSVC++ decides to throw in this case

Swap out unique for scoped lock and readd comment
Salvage преди 3 години
родител
ревизия
c586ac9be2
променени са 1 файла, в които са добавени 0 реда и са изтрити 3 реда
  1. 0 3
      src/core/hle/kernel/service_thread.cpp

+ 0 - 3
src/core/hle/kernel/service_thread.cpp

@@ -163,9 +163,6 @@ ServiceThread::Impl::~Impl() {
     m_wakeup_event->Signal();
     m_host_thread.join();
 
-    // Lock mutex.
-    m_session_mutex.lock();
-
     // Close all remaining sessions.
     for (const auto& [server_session, manager] : m_sessions) {
         server_session->Close();