Ver código fonte

arp: Prevent uninitialized read of launch member variable

If anything happened to call arp functions in the wrong order and called
IRegistrar's Issue function before SetApplicationLaunchProperty, we'd
read from an uninitialized ApplicationLaunchProperty instance.

Instead, we can always initialize it so if this does happen, then the
outcome of doing such a thing is at least consistently reproducible.
Lioncash 5 anos atrás
pai
commit
b7d04d848d
1 arquivos alterados com 1 adições e 1 exclusões
  1. 1 1
      src/core/hle/service/glue/arp.cpp

+ 1 - 1
src/core/hle/service/glue/arp.cpp

@@ -240,7 +240,7 @@ private:
 
     std::function<ResultCode(u64, ApplicationLaunchProperty, std::vector<u8>)> issue_process_id;
     bool issued = false;
-    ApplicationLaunchProperty launch;
+    ApplicationLaunchProperty launch{};
     std::vector<u8> control;
 };