Просмотр исходного кода

input_common/sdl/sdl_impl: Convert reinterpret_cast into a static_cast

It's valid to static_cast a void pointer back into its proper type.
Lioncash 7 лет назад
Родитель
Сommit
b73ea457cc
1 измененных файлов с 4 добавлено и 2 удалено
  1. 4 2
      src/input_common/sdl/sdl_impl.cpp

+ 4 - 2
src/input_common/sdl/sdl_impl.cpp

@@ -33,14 +33,16 @@ static std::string GetGUID(SDL_Joystick* joystick) {
 /// Creates a ParamPackage from an SDL_Event that can directly be used to create a ButtonDevice
 static Common::ParamPackage SDLEventToButtonParamPackage(SDLState& state, const SDL_Event& event);
 
-static int SDLEventWatcher(void* userdata, SDL_Event* event) {
-    SDLState* sdl_state = reinterpret_cast<SDLState*>(userdata);
+static int SDLEventWatcher(void* user_data, SDL_Event* event) {
+    auto* const sdl_state = static_cast<SDLState*>(user_data);
+
     // Don't handle the event if we are configuring
     if (sdl_state->polling) {
         sdl_state->event_queue.Push(*event);
     } else {
         sdl_state->HandleGameControllerEvent(*event);
     }
+
     return 0;
 }