Преглед на файлове

thread: Remove unnecessary memset from ResetThreadContext()

Regular value initialization is adequate here for zeroing out data. It
also has the benefit of not invoking undefined behavior if a non-trivial
type is ever added to the struct for whatever reason.
Lioncash преди 7 години
родител
ревизия
b492d43e63
променени са 1 файла, в които са добавени 1 реда и са изтрити 4 реда
  1. 1 4
      src/core/hle/kernel/thread.cpp

+ 1 - 4
src/core/hle/kernel/thread.cpp

@@ -183,13 +183,10 @@ void Thread::ResumeFromWait() {
  */
 static void ResetThreadContext(Core::ARM_Interface::ThreadContext& context, VAddr stack_top,
                                VAddr entry_point, u64 arg) {
-    memset(&context, 0, sizeof(Core::ARM_Interface::ThreadContext));
-
+    context = {};
     context.cpu_registers[0] = arg;
     context.pc = entry_point;
     context.sp = stack_top;
-    context.pstate = 0;
-    context.fpcr = 0;
 }
 
 ResultVal<SharedPtr<Thread>> Thread::Create(KernelCore& kernel, std::string name, VAddr entry_point,