Просмотр исходного кода

Dma_pusher: ASSERT on empty command_list

This is a measure to avoid crashes on command list reading as an empty
command_list is considered a NOP.
Fernando Sahmkow 7 лет назад
Родитель
Сommit
9e98100c94
1 измененных файлов с 7 добавлено и 0 удалено
  1. 7 0
      src/video_core/dma_pusher.cpp

+ 7 - 0
src/video_core/dma_pusher.cpp

@@ -40,6 +40,13 @@ bool DmaPusher::Step() {
     }
 
     const CommandList& command_list{dma_pushbuffer.front()};
+    ASSERT_OR_EXECUTE(!command_list.empty(), {
+        // Somehow the command_list is empty, in order to avoid a crash
+        // We ignore it and assume its size is 0.
+        dma_pushbuffer.pop();
+        dma_pushbuffer_subindex = 0;
+        return true;
+    });
     const CommandListHeader command_list_header{command_list[dma_pushbuffer_subindex++]};
     GPUVAddr dma_get = command_list_header.addr;
     GPUVAddr dma_put = dma_get + command_list_header.size * sizeof(u32);