Просмотр исходного кода

remove constexpr from virtual function

Signed-off-by: arades79 <scravers@protonmail.com>
arades79 3 лет назад
Родитель
Сommit
98631b45b6
2 измененных файлов с 5 добавлено и 5 удалено
  1. 2 2
      src/core/debugger/gdbstub_arch.cpp
  2. 3 3
      src/core/debugger/gdbstub_arch.h

+ 2 - 2
src/core/debugger/gdbstub_arch.cpp

@@ -41,7 +41,7 @@ static void PutSIMDRegister(std::array<u32, 64>& simd_regs, size_t offset, const
 
 // For sample XML files see the GDB source /gdb/features
 // This XML defines what the registers are for this specific ARM device
-constexpr std::string_view GDBStubA64::GetTargetXML() const {
+std::string_view GDBStubA64::GetTargetXML() const {
     return R"(<?xml version="1.0"?>
 <!DOCTYPE target SYSTEM "gdb-target.dtd">
 <target version="1.0">
@@ -267,7 +267,7 @@ u32 GDBStubA64::BreakpointInstruction() const {
     return 0xd4200000;
 }
 
-constexpr std::string_view GDBStubA32::GetTargetXML() const {
+std::string_view GDBStubA32::GetTargetXML() const {
     return R"(<?xml version="1.0"?>
 <!DOCTYPE target SYSTEM "gdb-target.dtd">
 <target version="1.0">

+ 3 - 3
src/core/debugger/gdbstub_arch.h

@@ -16,7 +16,7 @@ namespace Core {
 class GDBStubArch {
 public:
     virtual ~GDBStubArch() = default;
-    virtual constexpr std::string_view GetTargetXML() const = 0;
+    virtual std::string_view GetTargetXML() const = 0;
     virtual std::string RegRead(const Kernel::KThread* thread, size_t id) const = 0;
     virtual void RegWrite(Kernel::KThread* thread, size_t id, std::string_view value) const = 0;
     virtual std::string ReadRegisters(const Kernel::KThread* thread) const = 0;
@@ -27,7 +27,7 @@ public:
 
 class GDBStubA64 final : public GDBStubArch {
 public:
-    constexpr std::string_view GetTargetXML() const override;
+    std::string_view GetTargetXML() const override;
     std::string RegRead(const Kernel::KThread* thread, size_t id) const override;
     void RegWrite(Kernel::KThread* thread, size_t id, std::string_view value) const override;
     std::string ReadRegisters(const Kernel::KThread* thread) const override;
@@ -47,7 +47,7 @@ private:
 
 class GDBStubA32 final : public GDBStubArch {
 public:
-    constexpr std::string_view GetTargetXML() const override;
+    std::string_view GetTargetXML() const override;
     std::string RegRead(const Kernel::KThread* thread, size_t id) const override;
     void RegWrite(Kernel::KThread* thread, size_t id, std::string_view value) const override;
     std::string ReadRegisters(const Kernel::KThread* thread) const override;