Browse Source

Merge pull request #4848 from ReinUsesLisp/type-limits

video_core: Enforce -Werror=type-limits
LC 5 years ago
parent
commit
978e7897a3
2 changed files with 2 additions and 1 deletions
  1. 1 0
      src/video_core/CMakeLists.txt
  2. 1 1
      src/video_core/command_classes/codecs/vp9.cpp

+ 1 - 0
src/video_core/CMakeLists.txt

@@ -305,6 +305,7 @@ else()
         -Werror=pessimizing-move
         -Werror=pessimizing-move
         -Werror=redundant-move
         -Werror=redundant-move
         -Werror=switch
         -Werror=switch
+        -Werror=type-limits
         -Werror=unused-variable
         -Werror=unused-variable
 
 
         $<$<CXX_COMPILER_ID:GNU>:-Werror=class-memaccess>
         $<$<CXX_COMPILER_ID:GNU>:-Werror=class-memaccess>

+ 1 - 1
src/video_core/command_classes/codecs/vp9.cpp

@@ -893,7 +893,7 @@ void VpxRangeEncoder::Write(bool bit, s32 probability) {
         if (((low_value << (offset - 1)) >> 31) != 0) {
         if (((low_value << (offset - 1)) >> 31) != 0) {
             const s32 current_pos = static_cast<s32>(base_stream.GetPosition());
             const s32 current_pos = static_cast<s32>(base_stream.GetPosition());
             base_stream.Seek(-1, Common::SeekOrigin::FromCurrentPos);
             base_stream.Seek(-1, Common::SeekOrigin::FromCurrentPos);
-            while (base_stream.GetPosition() >= 0 && PeekByte() == 0xff) {
+            while (PeekByte() == 0xff) {
                 base_stream.WriteByte(0);
                 base_stream.WriteByte(0);
 
 
                 base_stream.Seek(-2, Common::SeekOrigin::FromCurrentPos);
                 base_stream.Seek(-2, Common::SeekOrigin::FromCurrentPos);