Explorar o código

service/am: Add missing return in error case for IStorageAccessor's Read()/Write().

Previously this would fall through and return successfully, despite
being an out of bounds read or write.
Lioncash %!s(int64=7) %!d(string=hai) anos
pai
achega
88c263ee8e
Modificáronse 1 ficheiros con 2 adicións e 0 borrados
  1. 2 0
      src/core/hle/service/am/am.cpp

+ 2 - 0
src/core/hle/service/am/am.cpp

@@ -835,6 +835,7 @@ void IStorageAccessor::Write(Kernel::HLERequestContext& ctx) {
 
         IPC::ResponseBuilder rb{ctx, 2};
         rb.Push(ERR_SIZE_OUT_OF_BOUNDS);
+        return;
     }
 
     std::memcpy(backing.buffer.data() + offset, data.data(), data.size());
@@ -857,6 +858,7 @@ void IStorageAccessor::Read(Kernel::HLERequestContext& ctx) {
 
         IPC::ResponseBuilder rb{ctx, 2};
         rb.Push(ERR_SIZE_OUT_OF_BOUNDS);
+        return;
     }
 
     ctx.WriteBuffer(backing.buffer.data() + offset, size);