Browse Source

telemetry_json: Take std::string parameters by value

Taking them by const reference isn't advisable here, because it means
the std::move calls were doing nothing and we were always copying the
std::string instances.
Lioncash 7 years ago
parent
commit
881bb2295d
2 changed files with 2 additions and 3 deletions
  1. 1 2
      src/web_service/telemetry_json.cpp
  2. 1 1
      src/web_service/telemetry_json.h

+ 1 - 2
src/web_service/telemetry_json.cpp

@@ -8,8 +8,7 @@
 
 
 namespace WebService {
 namespace WebService {
 
 
-TelemetryJson::TelemetryJson(const std::string& host, const std::string& username,
-                             const std::string& token)
+TelemetryJson::TelemetryJson(std::string host, std::string username, std::string token)
     : host(std::move(host)), username(std::move(username)), token(std::move(token)) {}
     : host(std::move(host)), username(std::move(username)), token(std::move(token)) {}
 TelemetryJson::~TelemetryJson() = default;
 TelemetryJson::~TelemetryJson() = default;
 
 

+ 1 - 1
src/web_service/telemetry_json.h

@@ -18,7 +18,7 @@ namespace WebService {
  */
  */
 class TelemetryJson : public Telemetry::VisitorInterface {
 class TelemetryJson : public Telemetry::VisitorInterface {
 public:
 public:
-    TelemetryJson(const std::string& host, const std::string& username, const std::string& token);
+    TelemetryJson(std::string host, std::string username, std::string token);
     ~TelemetryJson();
     ~TelemetryJson();
 
 
     void Visit(const Telemetry::Field<bool>& field) override;
     void Visit(const Telemetry::Field<bool>& field) override;