Просмотр исходного кода

gc_poller: Get rid of undefined behavior in Create()

Ensures that the function always has returns in all control paths.
Lioncash 6 лет назад
Родитель
Сommit
839c91cd14
1 измененных файлов с 4 добавлено и 0 удалено
  1. 4 0
      src/input_common/gcadapter/gc_poller.cpp

+ 4 - 0
src/input_common/gcadapter/gc_poller.cpp

@@ -6,6 +6,7 @@
 #include <list>
 #include <mutex>
 #include <utility>
+#include "common/assert.h"
 #include "common/threadsafe_queue.h"
 #include "input_common/gcadapter/gc_adapter.h"
 #include "input_common/gcadapter/gc_poller.h"
@@ -94,6 +95,9 @@ std::unique_ptr<Input::ButtonDevice> GCButtonFactory::Create(const Common::Param
         return std::make_unique<GCAxisButton>(port, axis, threshold, trigger_if_greater,
                                               adapter.get());
     }
+
+    UNREACHABLE();
+    return nullptr;
 }
 
 Common::ParamPackage GCButtonFactory::GetNextInput() {