Ver código fonte

mii_types: Remove null terminator check

This is an OoB array access, causing a crash on at least the Linux
Flatpak releases.

Co-authored-by: german77 <juangerman-13@hotmail.com>
lat9nq 2 anos atrás
pai
commit
77682aabd3
1 arquivos alterados com 1 adições e 4 exclusões
  1. 1 4
      src/core/hle/service/mii/mii_types.h

+ 1 - 4
src/core/hle/service/mii/mii_types.h

@@ -606,15 +606,12 @@ struct Nickname {
     static constexpr std::size_t MaxNameSize = 10;
     std::array<char16_t, MaxNameSize> data;
 
-    // Checks for null, non-zero terminated or dirty strings
+    // Checks for null or dirty strings
     bool IsValid() const {
         if (data[0] == 0) {
             return false;
         }
 
-        if (data[MaxNameSize] != 0) {
-            return false;
-        }
         std::size_t index = 1;
         while (data[index] != 0) {
             index++;