Explorar el Código

common: fs: file: Remove redundant call to WriteStringToFile

The Append open mode will create a new file if said file does not exist at a given path, making this call redundant.
Morph hace 5 años
padre
commit
74790e4f33
Se han modificado 2 ficheros con 1 adiciones y 6 borrados
  1. 0 4
      src/common/fs/file.cpp
  2. 1 2
      src/common/fs/file.h

+ 0 - 4
src/common/fs/file.cpp

@@ -183,10 +183,6 @@ size_t WriteStringToFile(const std::filesystem::path& path, FileType type,
 
 size_t AppendStringToFile(const std::filesystem::path& path, FileType type,
                           std::string_view string) {
-    if (!Exists(path)) {
-        return WriteStringToFile(path, type, string);
-    }
-
     if (!IsFile(path)) {
         return 0;
     }

+ 1 - 2
src/common/fs/file.h

@@ -71,7 +71,7 @@ template <typename Path>
 
 /**
  * Writes a string to a file at path and returns the number of characters successfully written.
- * If an file already exists at path, its contents will be erased.
+ * If a file already exists at path, its contents will be erased.
  * If the filesystem object at path is not a file, this function returns 0.
  *
  * @param path Filesystem path
@@ -95,7 +95,6 @@ template <typename Path>
 
 /**
  * Appends a string to a file at path and returns the number of characters successfully written.
- * If a file does not exist at path, WriteStringToFile is called instead.
  * If the filesystem object at path is not a file, this function returns 0.
  *
  * @param path Filesystem path