Browse Source

FS: Mark recursive CreateDirectory as inaccurate and temporary

Morph 4 years ago
parent
commit
727f607e00
1 changed files with 5 additions and 0 deletions
  1. 5 0
      src/core/hle/service/filesystem/filesystem.cpp

+ 5 - 0
src/core/hle/service/filesystem/filesystem.cpp

@@ -97,6 +97,11 @@ ResultCode VfsDirectoryServiceWrapper::DeleteFile(const std::string& path_) cons
 
 ResultCode VfsDirectoryServiceWrapper::CreateDirectory(const std::string& path_) const {
     std::string path(Common::FS::SanitizePath(path_));
+
+    // NOTE: This is inaccurate behavior. CreateDirectory is not recursive.
+    // CreateDirectory should return PathNotFound if the parent directory does not exist.
+    // This is here temporarily in order to have UMM "work" in the meantime.
+    // TODO (Morph): Remove this when a hardware test verifies the correct behavior.
     const auto components = Common::FS::SplitPathComponents(path);
     std::string relative_path;
     for (const auto& component : components) {