Browse Source

src/CMakeLists: Add /Zc:externConstexpr to the MSVC build flags

The C++ standard allows constexpr variables declared with the extern
keyword to have external linkage. Previously MSVC wasn't abiding by
this. This just makes the compiler more standards compliant during
builds.

Given we currently don't make use of anything that would break by this,
this is safe to enable.
Lioncash 7 năm trước cách đây
mục cha
commit
70c6506a7e
1 tập tin đã thay đổi với 10 bổ sung8 xóa
  1. 10 8
      src/CMakeLists.txt

+ 10 - 8
src/CMakeLists.txt

@@ -21,14 +21,15 @@ if (MSVC)
     # Ensure that projects build with Unicode support.
     add_definitions(-DUNICODE -D_UNICODE)
 
-    # /W3             - Level 3 warnings
-    # /MP             - Multi-threaded compilation
-    # /Zi             - Output debugging information
-    # /Zo             - Enhanced debug info for optimized builds
-    # /permissive-    - Enables stricter C++ standards conformance checks
-    # /EHsc           - C++-only exception handling semantics
-    # /Zc:inline      - Let codegen omit inline functions in object files
-    # /Zc:throwingNew - Let codegen assume `operator new` (without std::nothrow) will never return null
+    # /W3                 - Level 3 warnings
+    # /MP                 - Multi-threaded compilation
+    # /Zi                 - Output debugging information
+    # /Zo                 - Enhanced debug info for optimized builds
+    # /permissive-        - Enables stricter C++ standards conformance checks
+    # /EHsc               - C++-only exception handling semantics
+    # /Zc:externConstexpr - Allow extern constexpr variables to have external linkage, like the standard mandates
+    # /Zc:inline          - Let codegen omit inline functions in object files
+    # /Zc:throwingNew     - Let codegen assume `operator new` (without std::nothrow) will never return null
     add_compile_options(
         /W3
         /MP
@@ -37,6 +38,7 @@ if (MSVC)
         /permissive-
         /EHsc
         /std:c++latest
+        /Zc:externConstexpr
         /Zc:inline
         /Zc:throwingNew
     )