Просмотр исходного кода

maxwell_3d: update comments for shadow ram usage

namkazy 6 лет назад
Родитель
Сommit
7051dc1902

+ 1 - 1
src/video_core/engines/maxwell_3d.cpp

@@ -160,7 +160,7 @@ void Maxwell3D::CallMethod(const GPU::MethodCall& method_call) {
     ASSERT_MSG(method < Regs::NUM_REGS,
                "Invalid Maxwell3D register, increase the size of the Regs structure");
 
-    // Keep track of the register value in shadow_regs when requested.
+    // Keep track of the register value in shadow_state when requested.
     if (regs.shadow_ram_control == Regs::ShadowRamControl::Track ||
         regs.shadow_ram_control == Regs::ShadowRamControl::TrackWithFilter) {
         shadow_state.reg_array[method] = method_call.argument;

+ 4 - 0
src/video_core/engines/maxwell_3d.h

@@ -532,9 +532,13 @@ public:
         };
 
         enum class ShadowRamControl : u32 {
+            // write value to shadow ram
             Track = 0,
+            // write value to shadow ram ( with validation ??? )
             TrackWithFilter = 1,
+            // only write to real hw register
             Passthrough = 2,
+            // write value from shadow ram to real hw register
             Replay = 3,
         };
 

+ 1 - 1
src/video_core/macro_interpreter.cpp

@@ -328,7 +328,7 @@ void MacroInterpreter::SetMethodAddress(u32 address) {
 }
 
 void MacroInterpreter::Send(u32 value) {
-    // Use the tracked value in shadow_regs when requested.
+    // Use the tracked value in shadow_state when requested.
     if (method_address.address < Engines::Maxwell3D::Regs::NUM_REGS &&
         maxwell3d.shadow_state.shadow_ram_control ==
             Engines::Maxwell3D::Regs::ShadowRamControl::Replay) {