Răsfoiți Sursa

core/debugger: Define defaulted virtual destructors

Resolves an MSVC warning where a virtual destructor is not defined in the base class with virtual functions.
Morph 4 ani în urmă
părinte
comite
69511aed3d

+ 1 - 1
src/core/debugger/debugger.cpp

@@ -50,7 +50,7 @@ public:
         InitializeServer(port);
     }
 
-    ~DebuggerImpl() {
+    ~DebuggerImpl() override {
         ShutdownServer();
     }
 

+ 4 - 0
src/core/debugger/debugger_interface.h

@@ -24,6 +24,8 @@ enum class DebuggerAction {
 
 class DebuggerBackend {
 public:
+    virtual ~DebuggerBackend() = default;
+
     /**
      * Can be invoked from a callback to synchronously wait for more data.
      * Will return as soon as least one byte is received. Reads up to 4096 bytes.
@@ -51,6 +53,8 @@ class DebuggerFrontend {
 public:
     explicit DebuggerFrontend(DebuggerBackend& backend_) : backend{backend_} {}
 
+    virtual ~DebuggerFrontend() = default;
+
     /**
      * Called after the client has successfully connected to the port.
      */

+ 1 - 1
src/core/debugger/gdbstub.h

@@ -19,7 +19,7 @@ class System;
 class GDBStub : public DebuggerFrontend {
 public:
     explicit GDBStub(DebuggerBackend& backend, Core::System& system);
-    ~GDBStub();
+    ~GDBStub() override;
 
     void Connected() override;
     void Stopped(Kernel::KThread* thread) override;