Explorar el Código

sdl2_sink: Check for null string when loading SDL audio devices

Attempting to place a null string into a vector of strings causes an
error that closes the application.

Don't.
lat9nq hace 3 años
padre
commit
5c7eef3756
Se han modificado 1 ficheros con 4 adiciones y 1 borrados
  1. 4 1
      src/audio_core/sink/sdl2_sink.cpp

+ 4 - 1
src/audio_core/sink/sdl2_sink.cpp

@@ -230,7 +230,10 @@ std::vector<std::string> ListSDLSinkDevices(bool capture) {
 
     const int device_count = SDL_GetNumAudioDevices(capture);
     for (int i = 0; i < device_count; ++i) {
-        device_list.emplace_back(SDL_GetAudioDeviceName(i, 0));
+        const char* name = SDL_GetAudioDeviceName(i, 0);
+        if (name != nullptr) {
+            device_list.emplace_back(name);
+        }
     }
 
     return device_list;