소스 검색

yuzu/CMakeLists: Disable unsafe overloads of QProcess' start() function

Other overloads of start() are considerably much safer to use if we ever
need this in the future and need to pass arguments to the program, given
it contains separate parameters for the program path and the arguments
themselves, whereas this unsafe overload contains both as a single
string.

Given the alternatives are much safer, we can disable this.
Lioncash 7 년 전
부모
커밋
5b93290183
1개의 변경된 파일3개의 추가작업 그리고 0개의 파일을 삭제
  1. 3 0
      src/yuzu/CMakeLists.txt

+ 3 - 0
src/yuzu/CMakeLists.txt

@@ -162,6 +162,9 @@ target_compile_definitions(yuzu PRIVATE
 
     # Disable implicit type narrowing in signal/slot connect() calls.
     -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT
+
+    # Disable unsafe overloads of QProcess' start() function.
+    -DQT_NO_PROCESS_COMBINED_ARGUMENT_START
 )
 
 if (YUZU_ENABLE_COMPATIBILITY_REPORTING)