فهرست منبع

yuzu/applets/software_keyboard: Override accept() and reject() instead of providing own differently named member functions

Uses Qt's built-in interface instead of rolling our own separate one on
top of it. This also fixes a bug in reject() where we were calling
accept() instead of reject().
Lioncash 7 سال پیش
والد
کامیت
4dcdd3a837
2فایلهای تغییر یافته به همراه8 افزوده شده و 8 حذف شده
  1. 6 6
      src/yuzu/applets/software_keyboard.cpp
  2. 2 2
      src/yuzu/applets/software_keyboard.h

+ 6 - 6
src/yuzu/applets/software_keyboard.cpp

@@ -82,8 +82,8 @@ QtSoftwareKeyboardDialog::QtSoftwareKeyboardDialog(
                            : QString::fromStdU16String(parameters.submit_text),
                        QDialogButtonBox::AcceptRole);
 
-    connect(buttons, &QDialogButtonBox::accepted, this, &QtSoftwareKeyboardDialog::Submit);
-    connect(buttons, &QDialogButtonBox::rejected, this, &QtSoftwareKeyboardDialog::Reject);
+    connect(buttons, &QDialogButtonBox::accepted, this, &QtSoftwareKeyboardDialog::accept);
+    connect(buttons, &QDialogButtonBox::rejected, this, &QtSoftwareKeyboardDialog::reject);
     layout->addWidget(header_label);
     layout->addWidget(sub_label);
     layout->addWidget(guide_label);
@@ -96,16 +96,16 @@ QtSoftwareKeyboardDialog::QtSoftwareKeyboardDialog(
 
 QtSoftwareKeyboardDialog::~QtSoftwareKeyboardDialog() = default;
 
-void QtSoftwareKeyboardDialog::Submit() {
+void QtSoftwareKeyboardDialog::accept() {
     ok = true;
     text = line_edit->text().toStdU16String();
-    accept();
+    QDialog::accept();
 }
 
-void QtSoftwareKeyboardDialog::Reject() {
+void QtSoftwareKeyboardDialog::reject() {
     ok = false;
     text.clear();
-    accept();
+    QDialog::reject();
 }
 
 std::u16string QtSoftwareKeyboardDialog::GetText() const {

+ 2 - 2
src/yuzu/applets/software_keyboard.h

@@ -33,8 +33,8 @@ public:
                              Core::Frontend::SoftwareKeyboardParameters parameters);
     ~QtSoftwareKeyboardDialog() override;
 
-    void Submit();
-    void Reject();
+    void accept() override;
+    void reject() override;
 
     std::u16string GetText() const;
     bool GetStatus() const;