瀏覽代碼

gl_query_cache: Resolve use-after-move in CachedQuery move assignment operator

Avoids potential invalid junk data from being read.
Lioncash 6 年之前
父節點
當前提交
3a60f19eaf
共有 1 個文件被更改,包括 1 次插入1 次删除
  1. 1 1
      src/video_core/renderer_opengl/gl_query_cache.cpp

+ 1 - 1
src/video_core/renderer_opengl/gl_query_cache.cpp

@@ -94,9 +94,9 @@ CachedQuery::CachedQuery(CachedQuery&& rhs) noexcept
     : VideoCommon::CachedQueryBase<HostCounter>(std::move(rhs)), cache{rhs.cache}, type{rhs.type} {}
 
 CachedQuery& CachedQuery::operator=(CachedQuery&& rhs) noexcept {
-    VideoCommon::CachedQueryBase<HostCounter>::operator=(std::move(rhs));
     cache = rhs.cache;
     type = rhs.type;
+    CachedQueryBase<HostCounter>::operator=(std::move(rhs));
     return *this;
 }