Răsfoiți Sursa

decoders: Break instead of continue

continue causes a memory leak in A Hat in Time.
lat9nq 5 ani în urmă
părinte
comite
287a0f72a5
1 a modificat fișierele cu 2 adăugiri și 2 ștergeri
  1. 2 2
      src/video_core/textures/decoders.cpp

+ 2 - 2
src/video_core/textures/decoders.cpp

@@ -66,9 +66,9 @@ void Swizzle(std::span<u8> output, std::span<const u8> input, u32 bytes_per_pixe
                 if (const auto offset = (TO_LINEAR ? unswizzled_offset : swizzled_offset);
                 if (const auto offset = (TO_LINEAR ? unswizzled_offset : swizzled_offset);
                     offset >= input.size()) {
                     offset >= input.size()) {
                     // TODO(Rodrigo): This is an out of bounds access that should never happen. To
                     // TODO(Rodrigo): This is an out of bounds access that should never happen. To
-                    // avoid crashing the emulator, continue.
+                    // avoid crashing the emulator, break.
                     ASSERT_MSG(false, "offset {} exceeds input size {}!", offset, input.size());
                     ASSERT_MSG(false, "offset {} exceeds input size {}!", offset, input.size());
-                    continue;
+                    break;
                 }
                 }
 
 
                 u8* const dst = &output[TO_LINEAR ? swizzled_offset : unswizzled_offset];
                 u8* const dst = &output[TO_LINEAR ? swizzled_offset : unswizzled_offset];