瀏覽代碼

sdl_impl: Mark FromEvent() as a const member function

This doesn't modify internal member state, so it can be marked as const.
Lioncash 5 年之前
父節點
當前提交
2680526e6b
共有 1 個文件被更改,包括 2 次插入2 次删除
  1. 2 2
      src/input_common/sdl/sdl_impl.cpp

+ 2 - 2
src/input_common/sdl/sdl_impl.cpp

@@ -784,7 +784,7 @@ public:
         }
         }
         return {};
         return {};
     }
     }
-    std::optional<Common::ParamPackage> FromEvent(const SDL_Event& event) {
+    [[nodiscard]] std::optional<Common::ParamPackage> FromEvent(const SDL_Event& event) const {
         switch (event.type) {
         switch (event.type) {
         case SDL_JOYAXISMOTION:
         case SDL_JOYAXISMOTION:
             if (std::abs(event.jaxis.value / 32767.0) < 0.5) {
             if (std::abs(event.jaxis.value / 32767.0) < 0.5) {
@@ -795,7 +795,7 @@ public:
         case SDL_JOYHATMOTION:
         case SDL_JOYHATMOTION:
             return {SDLEventToButtonParamPackage(state, event)};
             return {SDLEventToButtonParamPackage(state, event)};
         }
         }
-        return {};
+        return std::nullopt;
     }
     }
 };
 };