Browse Source

kernel/svc: Simplify thread core ID sanitizing in CreateThread

Rather than use a switch here, this can be collapsed into a simple range
check, which is a little easier on the eyes.
Lioncash 7 năm trước cách đây
mục cha
commit
205e6d3b97
1 tập tin đã thay đổi với 1 bổ sung7 xóa
  1. 1 7
      src/core/hle/kernel/svc.cpp

+ 1 - 7
src/core/hle/kernel/svc.cpp

@@ -1233,13 +1233,7 @@ static ResultCode CreateThread(Handle* out_handle, VAddr entry_point, u64 arg, V
         ASSERT(processor_id != THREADPROCESSORID_IDEAL);
         ASSERT(processor_id != THREADPROCESSORID_IDEAL);
     }
     }
 
 
-    switch (processor_id) {
-    case THREADPROCESSORID_0:
-    case THREADPROCESSORID_1:
-    case THREADPROCESSORID_2:
-    case THREADPROCESSORID_3:
-        break;
-    default:
+    if (processor_id < THREADPROCESSORID_0 || processor_id > THREADPROCESSORID_3) {
         LOG_ERROR(Kernel_SVC, "Invalid thread processor ID: {}", processor_id);
         LOG_ERROR(Kernel_SVC, "Invalid thread processor ID: {}", processor_id);
         return ERR_INVALID_PROCESSOR_ID;
         return ERR_INVALID_PROCESSOR_ID;
     }
     }