Procházet zdrojové kódy

game_list_worker: Use QString's formatting instead of fmt in FormatPatchNameVersions()

Using fmt here requires unnecessary string conversions back into
QString. Instead, we can just use QString's formatting and get the end
result of the formatting operation in the proper type.
Lioncash před 7 roky
rodič
revize
1edf8660bc
1 změnil soubory, kde provedl 9 přidání a 4 odebrání
  1. 9 4
      src/yuzu/game_list_worker.cpp

+ 9 - 4
src/yuzu/game_list_worker.cpp

@@ -62,19 +62,24 @@ QString FormatPatchNameVersions(const FileSys::PatchManager& patch_manager,
     FileSys::VirtualFile update_raw;
     FileSys::VirtualFile update_raw;
     loader.ReadUpdateRaw(update_raw);
     loader.ReadUpdateRaw(update_raw);
     for (const auto& kv : patch_manager.GetPatchVersionNames(update_raw)) {
     for (const auto& kv : patch_manager.GetPatchVersionNames(update_raw)) {
-        if (!updatable && kv.first == "Update")
+        const bool is_update = kv.first == "Update";
+        if (!updatable && is_update) {
             continue;
             continue;
+        }
+
+        const QString type = QString::fromStdString(kv.first);
 
 
         if (kv.second.empty()) {
         if (kv.second.empty()) {
-            out.append(fmt::format("{}\n", kv.first).c_str());
+            out.append(QStringLiteral("%1\n").arg(type));
         } else {
         } else {
             auto ver = kv.second;
             auto ver = kv.second;
 
 
             // Display container name for packed updates
             // Display container name for packed updates
-            if (ver == "PACKED" && kv.first == "Update")
+            if (is_update && ver == "PACKED") {
                 ver = Loader::GetFileTypeString(loader.GetFileType());
                 ver = Loader::GetFileTypeString(loader.GetFileType());
+            }
 
 
-            out.append(fmt::format("{} ({})\n", kv.first, ver).c_str());
+            out.append(QStringLiteral("%1 (%2)\n").arg(type, QString::fromStdString(ver)));
         }
         }
     }
     }