Bladeren bron

Marked AppLoader_ELF, AppLoader_NCCH, and Archive_RomFS virtual functions as "override".

bunnei 12 jaren geleden
bovenliggende
commit
1099d83455
3 gewijzigde bestanden met toevoegingen van 13 en 13 verwijderingen
  1. 4 4
      src/core/file_sys/archive_romfs.h
  2. 2 2
      src/core/loader/elf.h
  3. 7 7
      src/core/loader/ncch.h

+ 4 - 4
src/core/file_sys/archive_romfs.h

@@ -20,13 +20,13 @@ namespace FileSys {
 class Archive_RomFS final : public Archive {
 public:
     Archive_RomFS(const Loader::AppLoader& app_loader);
-    ~Archive_RomFS();
+    ~Archive_RomFS() override;
 
     /**
      * Get the IdCode of the archive (e.g. RomFS, SaveData, etc.)
      * @return IdCode of the archive
      */
-    IdCode GetIdCode() const { return IdCode::RomFS; };
+    IdCode GetIdCode() const override { return IdCode::RomFS; };
 
     /**
      * Read data from the archive
@@ -35,13 +35,13 @@ public:
      * @param buffer Buffer to read data into
      * @return Number of bytes read
      */
-    size_t Read(const u64 offset, const u32 length, u8* buffer) const;
+    size_t Read(const u64 offset, const u32 length, u8* buffer) const override;
 
     /**
      * Get the size of the archive in bytes
      * @return Size of the archive in bytes
      */
-    size_t GetSize() const;
+    size_t GetSize() const override;
 
 private:
     std::vector<u8> raw_data;

+ 2 - 2
src/core/loader/elf.h

@@ -16,13 +16,13 @@ namespace Loader {
 class AppLoader_ELF final : public AppLoader {
 public:
     AppLoader_ELF(const std::string& filename);
-    ~AppLoader_ELF();
+    ~AppLoader_ELF() override;
 
     /**
      * Load the bootable file
      * @return ResultStatus result of function
      */
-    ResultStatus Load();
+    ResultStatus Load() override;
 
 private:
     std::string filename;

+ 7 - 7
src/core/loader/ncch.h

@@ -148,48 +148,48 @@ namespace Loader {
 class AppLoader_NCCH final : public AppLoader {
 public:
     AppLoader_NCCH(const std::string& filename);
-    ~AppLoader_NCCH();
+    ~AppLoader_NCCH() override;
 
     /**
      * Load the application
      * @return ResultStatus result of function
      */
-    ResultStatus Load();
+    ResultStatus Load() override;
 
     /**
      * Get the code (typically .code section) of the application
      * @param buffer Reference to buffer to store data
      * @return ResultStatus result of function
      */
-    ResultStatus ReadCode(std::vector<u8>& buffer) const;
+    ResultStatus ReadCode(std::vector<u8>& buffer) const override;
 
     /**
      * Get the icon (typically icon section) of the application
      * @param buffer Reference to buffer to store data
      * @return ResultStatus result of function
      */
-    ResultStatus ReadIcon(std::vector<u8>& buffer) const;
+    ResultStatus ReadIcon(std::vector<u8>& buffer) const override;
 
     /**
      * Get the banner (typically banner section) of the application
      * @param buffer Reference to buffer to store data
      * @return ResultStatus result of function
      */
-    ResultStatus ReadBanner(std::vector<u8>& buffer) const;
+    ResultStatus ReadBanner(std::vector<u8>& buffer) const override;
 
     /**
      * Get the logo (typically logo section) of the application
      * @param buffer Reference to buffer to store data
      * @return ResultStatus result of function
      */
-    ResultStatus ReadLogo(std::vector<u8>& buffer) const;
+    ResultStatus ReadLogo(std::vector<u8>& buffer) const override;
 
     /**
      * Get the RomFS of the application
      * @param buffer Reference to buffer to store data
      * @return ResultStatus result of function
      */
-    ResultStatus ReadRomFS(std::vector<u8>& buffer) const;
+    ResultStatus ReadRomFS(std::vector<u8>& buffer) const override;
 
 private: