Explorar el Código

key_manager: Use std::vector's insert() instead of std::copy with a back_inserter

If the data is unconditionally being appended to the back of a
std::vector, we can just directly insert it there without the need to
insert all of the elements one-by-one with a std::back_inserter.
Lioncash hace 7 años
padre
commit
06898263f6
Se han modificado 1 ficheros con 2 adiciones y 2 borrados
  1. 2 2
      src/core/crypto/key_manager.cpp

+ 2 - 2
src/core/crypto/key_manager.cpp

@@ -881,9 +881,9 @@ void KeyManager::DeriveETicket(PartitionDataManager& data) {
                                      "/system/save/80000000000000e2",
                                  "rb+");
 
+    const auto blob2 = GetTicketblob(save2);
     auto res = GetTicketblob(save1);
-    const auto res2 = GetTicketblob(save2);
-    std::copy(res2.begin(), res2.end(), std::back_inserter(res));
+    res.insert(res.end(), blob2.begin(), blob2.end());
 
     for (const auto& raw : res) {
         const auto pair = ParseTicket(raw, rsa_key);