Просмотр исходного кода

yuzu_cmd: Use string_view instead of string for extensions

Avoids potential allocations due to the usage of std::string on strings
that we know at compile time. Most of these might fit in SSO, but it
adds complexity that can be easily avoided with string views.
ReinUsesLisp 6 лет назад
Родитель
Сommit
028b1a34a9
1 измененных файлов с 3 добавлено и 3 удалено
  1. 3 3
      src/yuzu_cmd/emu_window/emu_window_sdl2_gl.cpp

+ 3 - 3
src/yuzu_cmd/emu_window/emu_window_sdl2_gl.cpp

@@ -50,7 +50,7 @@ private:
 };
 };
 
 
 bool EmuWindow_SDL2_GL::SupportsRequiredGLExtensions() {
 bool EmuWindow_SDL2_GL::SupportsRequiredGLExtensions() {
-    std::vector<std::string> unsupported_ext;
+    std::vector<std::string_view> unsupported_ext;
 
 
     if (!GLAD_GL_ARB_buffer_storage)
     if (!GLAD_GL_ARB_buffer_storage)
         unsupported_ext.push_back("ARB_buffer_storage");
         unsupported_ext.push_back("ARB_buffer_storage");
@@ -73,8 +73,8 @@ bool EmuWindow_SDL2_GL::SupportsRequiredGLExtensions() {
     if (!GLAD_GL_ARB_depth_buffer_float)
     if (!GLAD_GL_ARB_depth_buffer_float)
         unsupported_ext.push_back("ARB_depth_buffer_float");
         unsupported_ext.push_back("ARB_depth_buffer_float");
 
 
-    for (const std::string& ext : unsupported_ext)
-        LOG_CRITICAL(Frontend, "Unsupported GL extension: {}", ext);
+    for (const auto& extension : unsupported_ext)
+        LOG_CRITICAL(Frontend, "Unsupported GL extension: {}", extension);
 
 
     return unsupported_ext.empty();
     return unsupported_ext.empty();
 }
 }