فهرست منبع

gl_rasterizer: Replace magic number with GL_INVALID_INDEX in SetupConstBuffers()

This is just the named constant that OpenGL provides, so we can use that
instead of using a literal -1
Lioncash 8 سال پیش
والد
کامیت
0162f8b3a7
1فایلهای تغییر یافته به همراه5 افزوده شده و 3 حذف شده
  1. 5 3
      src/video_core/renderer_opengl/gl_rasterizer.cpp

+ 5 - 3
src/video_core/renderer_opengl/gl_rasterizer.cpp

@@ -689,10 +689,12 @@ u32 RasterizerOpenGL::SetupConstBuffers(Maxwell::ShaderStage stage, GLuint progr
         glBindBuffer(GL_UNIFORM_BUFFER, 0);
 
         // Now configure the bindpoint of the buffer inside the shader
-        std::string buffer_name = used_buffer.GetName();
-        GLuint index = glGetProgramResourceIndex(program, GL_UNIFORM_BLOCK, buffer_name.c_str());
-        if (index != -1)
+        const std::string buffer_name = used_buffer.GetName();
+        const GLuint index =
+            glGetProgramResourceIndex(program, GL_UNIFORM_BLOCK, buffer_name.c_str());
+        if (index != GL_INVALID_INDEX) {
             glUniformBlockBinding(program, index, buffer_draw_state.bindpoint);
+        }
     }
 
     state.Apply();